Summary: | Force elements with perspective or preserve-3d to disallow direct composited backgrounds | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | Layout and Rendering | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, noam, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2013-08-02 16:10:06 PDT
Created attachment 208053 [details]
Patch
Comment on attachment 208053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review > Source/WebCore/rendering/RenderLayerBacking.cpp:1518 > + if (hasPerspectiveOrPreserves3D(renderer->style())) > + return false; I think we need to do the same thing for simple image layers; they should show the same bug. (In reply to comment #3) > (From update of attachment 208053 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review > > > Source/WebCore/rendering/RenderLayerBacking.cpp:1518 > > + if (hasPerspectiveOrPreserves3D(renderer->style())) > > + return false; > > I think we need to do the same thing for simple image layers; they should show the same bug. Simple image layers can't have children, so nothing to intersect with. Comment on attachment 208053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review >>> Source/WebCore/rendering/RenderLayerBacking.cpp:1518 >>> + return false; >> >> I think we need to do the same thing for simple image layers; they should show the same bug. > > Simple image layers can't have children, so nothing to intersect with. True dat! > LayoutTests/compositing/background-color/no-composited-background-color-when-perspective-expected.html:16 > + background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAMAAAC6sdbXAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAA////pdmf3QAAAA5JREFUeNpiYMAHAAIMAAAeAAHMILKLAAAAAElFTkSuQmCC"); This might fall into a future background-image optimization. Maybe better to use border: 5px solid black and box-sizing: foo. Comment on attachment 208053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208053&action=review >> LayoutTests/compositing/background-color/no-composited-background-color-when-perspective-expected.html:16 >> + background-image: url("data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAUAAAAFCAMAAAC6sdbXAAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAAZQTFRFAAAA////pdmf3QAAAA5JREFUeNpiYMAHAAIMAAAeAAHMILKLAAAAAElFTkSuQmCC"); > > This might fall into a future background-image optimization. Maybe better to use border: 5px solid black and box-sizing: foo. Yeah, but unfortunately that slightly changes either the perspective origin or the transform origin. I'm not sure why this is - sounds like a bug! Committed r153681: <http://trac.webkit.org/changeset/153681> |