|Summary:||REGRESSION: inheritableProperties arrays in CSSMutableStyleDeclaration.cpp and CSSComputedStyleDeclaration.cpp are out of sync (failing editing/pasteboard/paste-table-002.html and fast/lists/drag-into-marker.html)|
|Component:||CSS||Assignee:||Dave Hyatt <hyatt>|
|OS:||OS X 10.4|
Description mitz 2006-12-23 02:26:28 PST
The inheritableProperties arrays in CSSMutableStyleDeclaration.cpp and CSSComputedStyleDeclaration.cpp differ. Most recently, the text-stroke properties were added only in CSSComputedStyleDeclaration.cpp, making editing/pasteboard/paste-table-002.html and fast/lists/drag-into-marker.html fail (the latter only in pixel mode). There was an earlier discrepancy, where one array had CSS_PROP_BORDER_SPACING and the other had CSS_PROP__WEBKIT_BORDER_HORIZONTAL_SPACING and CSS_PROP__WEBKIT_BORDER_VERTICAL_SPACING. Can the array be shared between the two implementations?
Comment 1 mitz 2006-12-23 02:33:49 PST
I'm not convinced that CSSMutableStyleDeclaration::removeInheritableProperties should exist as a method in that class. Since this it's ultimately about properties that can be computed, perhaps a static method in CSSComputedStyleDeclaration would be better.
Comment 2 Dave Hyatt 2006-12-23 04:48:32 PST
Created attachment 11982 [details] Sync up the two arrays How lame. I added comments to help avoid this mistake in the future.
Comment 3 mitz 2006-12-23 04:51:38 PST
Comment on attachment 11982 [details] Sync up the two arrays r=me
Comment 5 mitz 2006-12-23 06:40:11 PST
Still failing editing/pasteboard/paste-table-002.html, but now I think it just needs updated expected results.