Bug 119419

Summary:

[Forms: color] WebColorPickerMac deconstructor shouldn't assert a variable

Product:

WebKit

Reporter:

Ruth Fong <ruthiecftg>

Component:

Forms

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bdakin, beidson, benjamin, commit-queue, jonlee, ruthiecftg, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Ruth Fong 2013-08-01 17:58:22 PDT

In WebColorPickerMac.mm, ~WebColorPickerMac asserts to see if one of its variables is null. Instead it should check to see if its null; if not, it should properly invalidate it.

Comment 1 Radar WebKit Bug Importer 2013-08-01 18:00:58 PDT

<rdar://problem/14627633>

Comment 2 Ruth Fong 2013-08-02 10:53:52 PDT

Created attachment 208033 [details]
Patch

Comment 3 Tim Horton 2013-08-02 11:27:24 PDT

Comment on attachment 208033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208033&action=review

> Source/WebKit2/UIProcess/mac/WebColorPickerMac.mm:-85
> -#if ENABLE(INPUT_TYPE_COLOR_POPOVER)

So, we need to endPicker() for all <input type='color'>?

Comment 4 WebKit Commit Bot 2013-08-02 14:34:26 PDT

Comment on attachment 208033 [details]
Patch

Clearing flags on attachment: 208033

Committed r153670: <http://trac.webkit.org/changeset/153670>

Comment 5 WebKit Commit Bot 2013-08-02 14:34:27 PDT

All reviewed patches have been landed.  Closing bug.