Bug 119415

Summary: [Windows] WebKit1 Full Screen Video Play on Windows is Broken
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Severity: Normal CC: commit-queue, eric.carlson, glenn, jer.noble, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
Patch jer.noble: review+

Description Brent Fulgham 2013-08-01 15:43:40 PDT
Switching to "Full Screen" mode while playing a video in WinLauncher does not work.  Video renders as a blank, red, screen.  Moving back to normal move leaves the player screen blank (though captions and audio still play).
Comment 1 Brent Fulgham 2013-08-01 15:45:18 PDT
Comment 2 Brent Fulgham 2013-08-01 16:02:17 PDT
Created attachment 207967 [details]
Comment 3 Jer Noble 2013-08-01 16:45:49 PDT
Comment on attachment 207967 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=207967&action=review

> Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:42
> +    virtual bool manualCreateRenderer() { return createRenderer(); }
> +

We should just make createRenderer() public rather than make a public alias.

> Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:82
> -    ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"", WS_POPUP, 
> +    m_hwnd = ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"", WS_POPUP, 

This isn't necessary as m_hwnd will be set in a WM_CREATE message during this call. (That's what the ASSERT below is checking.)

Other than those nits, LGTM.
Comment 4 Brent Fulgham 2013-08-01 17:05:56 PDT
Committed r153628: <http://trac.webkit.org/changeset/153628>