Summary: | [Windows] WebKit1 Full Screen Video Play on Windows is Broken | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, eric.carlson, glenn, jer.noble, simon.fraser | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brent Fulgham
2013-08-01 15:43:40 PDT
Created attachment 207967 [details]
Patch
Comment on attachment 207967 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207967&action=review > Source/WebCore/platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:42 > + virtual bool manualCreateRenderer() { return createRenderer(); } > + We should just make createRenderer() public rather than make a public alias. > Source/WebCore/platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:82 > - ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"", WS_POPUP, > + m_hwnd = ::CreateWindowExW(WS_EX_TOOLWINDOW, windowClassName, L"", WS_POPUP, This isn't necessary as m_hwnd will be set in a WM_CREATE message during this call. (That's what the ASSERT below is checking.) Other than those nits, LGTM. Committed r153628: <http://trac.webkit.org/changeset/153628> |