Bug 11941 – REGRESSION: Missing text stroke in svg/W3C-SVG-1.1/text-deco-01-b.svg

• Component: SVG
• Status: RESOLVED FIXED

svg/W3C-SVG-1.1/text-deco-01-b.svg is failing in pixel mode. Some of the text is not stroked.

In r18436 a new version of text-deco-01-b.svg was checked in along with results generated with TOT, so the regression may no longer be causing a test failure. When fixing this bug (or sooner), updated results should be generated and checked in.

*** Bug 12012 has been marked as a duplicate of this bug. ***

As a quick fix for the regression, you can restore stroke thickness to whatever it was before returning from InlineFlowBox::paintDecorations(). That would still leave the text decorations broken, but no more broken than they used to be (SVG text decorations should be filled and stroked, with both fill and stroke being behind or in front of the text, depending on the decoration).

[Rob Buis]

Created attachment 12141 [details]
first attempt

This should fix it. AFAICS only this test is really affected.
Cheers,

Rob.

[Oliver Hunt]

Comment on attachment 12141 [details]
first attempt

should
+//            const_cast<RenderObject*>(object)->style()->setTextFillColor(Color());
really be Color()?

[Dave Hyatt]

Comment on attachment 12141 [details]
first attempt

I assume you need to still do setColor() down both code paths?

 If stroke/fill is invalid in CSS, then color is used again.

[Eric Seidel (no email)]

Comment on attachment 12141 [details]
first attempt

Um... I don't think we're supposed to be mutating RenderStyles.  I think this just came up when talking to hyatt on IRC.

[Maciej Stachowiak]

<rdar://problem/4960653>

[Nikolas Zimmermann]

The new SVG text engine fixes this problem.

*** This bug has been marked as a duplicate of 12698 ***

Reopening because this is not fixed on trunk after bug 12698 was fixed on the feature branch.

[Eric Seidel (no email)]

This is definitely fixed on feature branch.

(In reply to comment #11)
> This is definitely fixed on feature branch.

Yet broken on trunk. I think bugzilla tracks trunk, which is why I reopened.