Bug 119359

Summary: More cleanup in PropertySlot
Product: WebKit Reporter: Gavin Barraclough <barraclough>
Component: JavaScriptCoreAssignee: Gavin Barraclough <barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
fix ggaren: review+

Gavin Barraclough
Reported 2013-07-31 16:55:29 PDT
m_slotBase is overloaded to store the (receiver) thisValue and the object that contains the property, This is confusing, and means that slotBase cannot be typed correctly (can only be a JSObject).
Attachments
fix (14.54 KB, patch)
2013-07-31 16:56 PDT, Gavin Barraclough 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-07-31 16:56:58 PDT
Created attachment 207888 [details] fix
Geoffrey Garen
Comment 2 2013-07-31 16:59:19 PDT
Comment on attachment 207888 [details] fix r=me
WebKit Commit Bot
Comment 3 2013-07-31 16:59:44 PDT
Attachment 207888 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/runtime/JSObject.cpp', u'Source/JavaScriptCore/runtime/JSObject.h', u'Source/JavaScriptCore/runtime/PropertySlot.cpp', u'Source/JavaScriptCore/runtime/PropertySlot.h', u'Source/JavaScriptCore/runtime/SparseArrayValueMap.cpp', u'Source/JavaScriptCore/runtime/SparseArrayValueMap.h']" exit_code: 1 Source/JavaScriptCore/runtime/PropertySlot.h:62: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/PropertySlot.h:62: The parameter name "propertyName" adds no information, so it should be removed. [readability/parameter_name] [5] Source/JavaScriptCore/runtime/PropertySlot.h:63: The parameter name "exec" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 3 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 4 2013-07-31 18:08:17 PDT
Committed revision 153556.
Note You need to log in before you can comment on or make changes to this bug.