Bug 119341

Summary:

Define DOM_KEY_LOCATION_* constants on KeyboardEvent

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

WebCore Misc.

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, benjamin, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, laszlo.gombos, rakuco, rniwa

Priority:

Keywords:

BlinkMergeCandidate, WebExposed

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

119326

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Patch	rniwa: review+
Patch for landing	none

Chris Dumez

Reported 2013-07-31 10:14:08 PDT

Define DOM_KEY_LOCATION_* constants on the KeyboardEvent interface to match the latest specification: http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent Those constants are already supported by IE10, Firefox 22 and since recently Blink. Note that the following constants are not supported internally yet. Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=155231&view=revision

Attachments
Patch (35.33 KB, patch) 2013-08-11 23:56 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (36.29 KB, patch) 2013-08-12 00:26 PDT, Chris Dumez	rniwa: review+	Details Formatted Diff Diff
Patch for landing (37.04 KB, patch) 2013-08-12 06:37 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2013-08-11 23:56:55 PDT

Created attachment 208511 [details] Patch

WebKit Commit Bot

Comment 2 2013-08-11 23:59:34 PDT

Attachment 208511 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1 Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 4 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.

Chris Dumez

Comment 3 2013-08-12 00:26:45 PDT

Created attachment 208512 [details] Patch

WebKit Commit Bot

Comment 4 2013-08-12 00:29:51 PDT

Attachment 208512 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants-expected.txt', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1 Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 4 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.

Ryosuke Niwa

Comment 5 2013-08-12 00:32:33 PDT

Comment on attachment 208512 [details] Patch Looks reasonable.

Chris Dumez

Comment 6 2013-08-12 06:37:14 PDT

Created attachment 208537 [details] Patch for landing Rebaseline fast/events/js-keyboard-event-creation.html on all platforms, not just EFL.

WebKit Commit Bot

Comment 7 2013-08-12 06:38:32 PDT

Attachment 208537 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation-expected.txt', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants-expected.txt', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'LayoutTests/platform/gtk/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1 Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 4 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 8 2013-08-12 12:46:02 PDT

Comment on attachment 208537 [details] Patch for landing Clearing flags on attachment: 208537 Committed r153955: <http://trac.webkit.org/changeset/153955>

WebKit Commit Bot

Comment 9 2013-08-12 12:46:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.