Summary: | Define DOM_KEY_LOCATION_* constants on KeyboardEvent | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||
Component: | WebCore Misc. | Assignee: | Chris Dumez <cdumez> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, benjamin, commit-queue, darin, esprehn+autocc, gyuyoung.kim, kangil.han, kondapallykalyan, laszlo.gombos, rakuco, rniwa | ||||||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, WebExposed | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | 119326 | ||||||||||
Bug Blocks: | |||||||||||
Attachments: |
|
Description
Chris Dumez
2013-07-31 10:14:08 PDT
Created attachment 208511 [details]
Patch
Attachment 208511 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1
Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 4 in 14 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 208512 [details]
Patch
Attachment 208512 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants-expected.txt', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1
Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 4 in 15 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 208512 [details]
Patch
Looks reasonable.
Created attachment 208537 [details]
Patch for landing
Rebaseline fast/events/js-keyboard-event-creation.html on all platforms, not just EFL.
Attachment 208537 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast/events/constructors/keyboard-event-constructor-expected.txt', u'LayoutTests/fast/events/constructors/keyboard-event-constructor.html', u'LayoutTests/fast/events/js-keyboard-event-creation-expected.txt', u'LayoutTests/fast/events/js-keyboard-event-creation.html', u'LayoutTests/fast/events/keyboardevent-location-constants-expected.txt', u'LayoutTests/fast/events/keyboardevent-location-constants.html', u'LayoutTests/fast/events/keydown-leftright-keys-expected.txt', u'LayoutTests/fast/events/keydown-leftright-keys.html', u'LayoutTests/fast/events/keydown-numpad-keys-expected.txt', u'LayoutTests/fast/events/script-tests/keydown-numpad-keys.js', u'LayoutTests/platform/efl/fast/events/js-keyboard-event-creation-expected.txt', u'LayoutTests/platform/gtk/fast/events/js-keyboard-event-creation-expected.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/KeyboardEvent.idl']" exit_code: 1
Source/WebCore/dom/KeyboardEvent.h:62: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:63: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:64: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Source/WebCore/dom/KeyboardEvent.h:65: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
Total errors found: 4 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 208537 [details] Patch for landing Clearing flags on attachment: 208537 Committed r153955: <http://trac.webkit.org/changeset/153955> All reviewed patches have been landed. Closing bug. |