Bug 119315
| Summary: | Cut down the SVG test times by half | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WONTFIX | ||
| Severity: | Normal | CC: | jberlin, kling, koivisto, krit, lforschler, pdr, thorton |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Merge https://chromium.googlesource.com/chromium/blink/+/8112adfbb23dbcec43fcacc9feaf60a69465be1c
All the tests in the patch wait unnecessarily for another 100ms
when the animation runs for less than 100ms.
The comment in the tests mentions waiting another 100ms for repaint
but in actual the repaint times are few milli secs.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Philip Rogers
Don't merge this.
The title overstates what the patch does a bit :P In any case, we had to roll it out later due to flakiness.
Philip Rogers
For completeness, the rollout occurred in http://src.chromium.org/viewvc/blink?view=revision&revision=154856
This area is still ripe for optimization. The original patch author deemed it "too hard" and abandoned the patch, but I don't think it's actually that hard.
Ryosuke Niwa
Okay. Thanks for the clarification.