Bug 119314

Summary:	Make SVGTRefElement use the modern Shadow DOM API
Product:	WebKit	Reporter:	Ryosuke Niwa <rniwa>
Component:	SVG	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED WONTFIX
Severity:	Normal	CC:	ahmad.saleem792, ap, bfulgham, kling, koivisto, simon.fraser, thorton, zalan, zimmermann
Priority:	P2	Keywords:	BlinkMergeCandidate
Version:	528+ (Nightly build)
Hardware:	Unspecified
OS:	Unspecified

Description Ryosuke Niwa 2013-07-30 21:19:22 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/051f9e94c22419b5282383d6e37629d77c728ac5

We can simplify SVGTRefElement by using modern Shadow DOM abstractions like
userAgentShadowRoot() and utility functions like replaceChildrenWithText.

Comment 1 Ahmad Saleem 2022-08-13 16:04:11 PDT

This one looks pretty similar to Blink patch modification and it seems that it was not modified:

https://github.com/WebKit/WebKit/blob/a8766e9cb3f1d5446226413afe0de6b0a64dc996/Source/WebCore/svg/SVGTRefElement.cpp#L139

This one looks changed compared to Blink:

https://github.com/WebKit/WebKit/blob/8afe31a018b11741abdf9b4d5bb973d7c1d9ff05/Source/WebCore/svg/SVGTRefElement.h#L48

_____

rniwa@webkit.org - It is going to be "RESOLVED LATER" or it is something can be landed with slightly changes or web-specs are changed due to SVG2 and it is not relevant? Thanks!

Comment 2 Ryosuke Niwa 2022-08-13 19:16:20 PDT

The old code is still there.

Comment 3 Ahmad Saleem 2022-10-06 16:26:20 PDT

I tried to did this change here - https://github.com/WebKit/WebKit/pull/5005

But later realised that Chrome / Blink removed this <TREF> support later in September in below commit:

https://src.chromium.org/viewvc/blink?revision=157630&view=revision

I think we are failing WPT tests because of that as well and any modernisation would be fool's errand. I am going to mark this as "RESOLVED WONTFIX". Thanks!