Bug 11930

Summary: Specifying border-radius makes the outline shrink
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin
Priority: P2 Keywords: EasyFix, HasReduction
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Test case
none
Prevent fallthrough
ggaren: review+
Prevent fallthrough ggaren: review+

mitz
Reported 2006-12-22 07:35:16 PST
An object's outline is inset by 1 pixel if the -webkit-border-radius property is specified, even if the specified value is 0 and there is no border. See test case.
Attachments
Test case (225 bytes, text/html)
2006-12-22 07:35 PST, mitz 		no flags
Details
Prevent fallthrough (1014 bytes, patch)
2006-12-26 09:14 PST, mitz 		ggaren: review+
DetailsFormatted DiffDiff
Prevent fallthrough (27.58 KB, patch)
2006-12-26 12:03 PST, mitz 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2006-12-22 07:35:50 PST
Created attachment 11967 [details] Test case
mitz
Comment 2 2006-12-22 08:23:41 PST
This is caused by a missing return at the end of the CSS_PROP__WEBKIT_BORDER_BOTTOM_RIGHT_RADIUS case in CSSStyleSelector::applyProperty(), causing fallthrough to the CSS_PROP_OUTLINE_OFFSET case.
mitz
Comment 3 2006-12-26 09:14:24 PST
Created attachment 12034 [details] Prevent fallthrough Let me know if a regression test is needed.
Geoffrey Garen
Comment 4 2006-12-26 10:34:14 PST
Comment on attachment 12034 [details] Prevent fallthrough The policy is that all patches should come with a regression test unless it's really not feasible or there's no change in behavior. I'll r+ this, but please land it with a test.
mitz
Comment 5 2006-12-26 12:03:04 PST
Created attachment 12040 [details] Prevent fallthrough Added pixel test.
Geoffrey Garen
Comment 6 2006-12-26 12:14:40 PST
Comment on attachment 12040 [details] Prevent fallthrough r=me
Sam Weinig
Comment 7 2006-12-27 15:40:56 PST
Landed in r18442.
Note You need to log in before you can comment on or make changes to this bug.