Bug 119287 – Remove non-sensical code to force body/documentElement layout in FrameView::layout

• Component: Layout and Rendering
• Status: NEW

[Ryosuke Niwa]

Consider merging https://chromium.googlesource.com/chromium/blink/+/efb3a87ef7691e129f3c50895cf6f6ad89f15e19

FrameView::layout() should only be about updating the layout of renderers which
need a layout update. It should not need to force renderers to layout.  If it's
doing that, then some other code has failed to correctly invalidate the layout
of those renderers.

This used to be for FrameFlattening (which is still part of seamless), but has morphed over the years.  I'm not sure it was ever really needed.  See:
http://trac.webkit.org/browser/trunk/WebCore/page/FrameView.cpp?annotate=blame&rev=73116#L501

And:
http://trac.webkit.org/changeset/73117

[Ahmad Saleem]

Seems this full can go away - https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/FrameView.cpp#L1268

[Ahmad Saleem]

(In reply to Ahmad Saleem from comment #1)
> Seems this full can go away -
> https://github.com/WebKit/WebKit/blob/main/Source/WebCore/page/FrameView.
> cpp#L1268

Just to refresh the source now:

https://searchfox.org/wubkat/source/Source/WebCore/page/LocalFrameView.cpp#1280

With function name: LocalFrameView::markRootOrBodyRendererDirty()

^ Would be easier to find in future.

[Ahmad Saleem]

@Alan - looking into code changes to make 'markRootOrBodyRendererDirty' as separate function, it was done by yourself in following commit:

https://commits.webkit.org/195119@main

Is this Blink commit relevant to merge or we can mark this as 'RESOLVED WONTFIX'?