Bug 119241

Summary: Remove guessesVector param from isUngrammatical
Product: WebKit Reporter: Grzegorz Czajkowski <g.czajkowski>
Component: HTML EditingAssignee: Grzegorz Czajkowski <g.czajkowski>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
rniwa: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 none

Description Grzegorz Czajkowski 2013-07-30 02:37:37 PDT
Cleanup.
Comment 1 Grzegorz Czajkowski 2013-07-30 02:40:35 PDT
Created attachment 207706 [details]
proposed patch
Comment 2 Build Bot 2013-07-30 03:34:59 PDT
Comment on attachment 207706 [details]
proposed patch

Attachment 207706 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1293280

New failing tests:
editing/selection/leak-document-with-selection-inside.html
Comment 3 Build Bot 2013-07-30 03:35:00 PDT
Created attachment 207712 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 4 Ryosuke Niwa 2013-07-30 12:09:23 PDT
Comment on attachment 207706 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207706&action=review

> Source/WebCore/editing/Editor.cpp:1870
>  Vector<String> Editor::guessesForUngrammaticalSelection()
>  {

Can we remove this function?
Comment 5 Grzegorz Czajkowski 2013-07-30 12:33:55 PDT
(In reply to comment #4)
> (From update of attachment 207706 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207706&action=review
> 
> > Source/WebCore/editing/Editor.cpp:1870
> >  Vector<String> Editor::guessesForUngrammaticalSelection()
> >  {
> 
> Can we remove this function?

It is still called in http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L1919. Should we remove this block as well?
Thanks for review!
Comment 6 Ryosuke Niwa 2013-07-30 12:35:57 PDT
(In reply to comment #5)
>
> It is still called in http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L1919. Should we remove this block as well?
> Thanks for review!

It seems like we should if that code is never used.
Comment 7 Grzegorz Czajkowski 2013-07-30 12:39:07 PDT
(In reply to comment #6)
> (In reply to comment #5)
> >
> > It is still called in http://trac.webkit.org/browser/trunk/Source/WebCore/editing/Editor.cpp#L1919. Should we remove this block as well?
> > Thanks for review!
> 
> It seems like we should if that code is never used.

Ok, I'll get rid of it while submitting.
Comment 8 Grzegorz Czajkowski 2013-07-31 02:43:56 PDT
Committed r153515: <http://trac.webkit.org/changeset/153515>