Bug 119239

Summary: Missing the rename REGISTER_PROCOTOL_HANDLER Macro to NAVIGATOR_CONTENT_UTILS in WebKitLibraries
Product: WebKit Reporter: Sanghyun Park <sh919.park>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, commit-queue, dw.im, gyuyoung.kim, laszlo.gombos, paroga
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 94920    
Attachments:
Description Flags
Initial patch! none

Sanghyun Park
Reported 2013-07-30 01:51:43 PDT
Missing the rename REGISTER_PROCOTOL_HANDLER Macro to NAVIGATOR_CONTENT_UTILS in WebKitLibraries According to "https://bugs.webkit.org/show_bug.cgi?id=94920", REGISTER_PROCOTOL_HANDLER macro was changed to NAVIGATOR_CONTENT_UTILS. But, FeatureDefines.props and FeatureDefinesCairo.props was not changed.
Attachments
Initial patch! (11.52 KB, patch)
2013-07-30 03:22 PDT, Sanghyun Park 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sanghyun Park
Comment 1 2013-07-30 03:22:06 PDT
Created attachment 207710 [details] Initial patch!
Brent Fulgham
Comment 2 2013-07-30 09:13:11 PDT
Yikes! We must not have tests on Windows for this logic, or else we should have noticed this issue.
Brent Fulgham
Comment 3 2013-07-30 09:13:58 PDT
Comment on attachment 207710 [details] Initial patch! r=me
WebKit Commit Bot
Comment 4 2013-07-30 09:16:57 PDT
Comment on attachment 207710 [details] Initial patch! Clearing flags on attachment: 207710 Committed r153473: <http://trac.webkit.org/changeset/153473>
WebKit Commit Bot
Comment 5 2013-07-30 09:17:00 PDT
All reviewed patches have been landed. Closing bug.
Sanghyun Park
Comment 6 2013-07-30 19:37:30 PDT
(In reply to comment #2) > Yikes! We must not have tests on Windows for this logic, or else we should have noticed this issue. Thank you for review :)
Note You need to log in before you can comment on or make changes to this bug.