| Summary: | Don't update the text track override CSS every time a media element is created. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||
| Component: | Accessibility | Assignee: | Andreas Kling <kling> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, dino, eric.carlson, glenn, jer.noble, kling, koivisto, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar, Performance | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Andreas Kling
2013-07-28 19:13:22 PDT
Created attachment 207617 [details]
Patch
Comment on attachment 207617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207617&action=review > Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:238 > + updateCaptionStyleSheetOveride(); I would suggest instead changing this function to use early return if already listening for preference changes rather than nesting all this code inside an if statement. Comment on attachment 207617 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207617&action=review >> Source/WebCore/page/CaptionUserPreferencesMediaAF.cpp:238 >> + updateCaptionStyleSheetOveride(); > > I would suggest instead changing this function to use early return if already listening for preference changes rather than nesting all this code inside an if statement. And fix the spelling while you're at it :) Comment on attachment 207617 [details] Patch Clearing flags on attachment: 207617 Committed r153418: <http://trac.webkit.org/changeset/153418> All reviewed patches have been landed. Closing bug. |