Summary: | Some cleanup in PropertySlot | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gavin Barraclough <barraclough> | ||||||
Component: | JavaScriptCore | Assignee: | Gavin Barraclough <barraclough> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, ggaren, oliver | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gavin Barraclough
2013-07-27 23:43:27 PDT
Created attachment 207603 [details]
fix
Attachment 207603 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/runtime/PropertySlot.cpp', u'Source/JavaScriptCore/runtime/PropertySlot.h']" exit_code: 1
Source/JavaScriptCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:17: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 207603 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=207603&action=review > Source/JavaScriptCore/runtime/PropertySlot.h:205 > + unsigned index() const { return m_data.customIndex.index; } Can we ASSERT that the m_propertyType is TypeCustomIndex here? Comment on attachment 207603 [details] fix View in context: https://bugs.webkit.org/attachment.cgi?id=207603&action=review > Source/JavaScriptCore/runtime/PropertySlot.h:50 > enum CachedPropertyType { > - Uncacheable, > - Getter, > - Custom, > - Value > + Uncacheable = TypeUnset, > + Value = TypeValue, > + Getter = TypeGetter, > + Custom = TypeCustom Can you do something to help distinguish these names as being the cacheable variants? Maybe "CacheableValue", etc.? Created attachment 207674 [details]
fix
> Can we ASSERT that the m_propertyType is TypeCustomIndex here?
Cleaned up a bit more - removed this method.
Attachment 207674 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source/JavaScriptCore/dfg/DFGRepatch.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess.cpp', u'Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp', u'Source/JavaScriptCore/jit/JITStubs.cpp', u'Source/JavaScriptCore/llint/LLIntSlowPaths.cpp', u'Source/JavaScriptCore/runtime/PropertySlot.cpp', u'Source/JavaScriptCore/runtime/PropertySlot.h']" exit_code: 1
Source/JavaScriptCore/ChangeLog:14: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:15: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:16: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Source/JavaScriptCore/ChangeLog:17: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 4 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
> Can you do something to help distinguish these names as being the cacheable variants? Maybe "CacheableValue", etc.?
Was going to tidy up the external interface in a follow up patch, but was simple enough. Removed this enum, added more methods matching existing isCacheableValue() instead.
Comment on attachment 207674 [details]
fix
r=me
Fixed in r153454 |