Bug 119181 – RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Andreas Kling]

RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*.

[Andreas Kling]

Created attachment 207591 [details]
Patch

[EFL EWS Bot]

Comment on attachment 207591 [details]
Patch

Attachment 207591 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1248574

[Andreas Kling]

Comment on attachment 207591 [details]
Patch

Meh, the EFL EWS bot had some internal compiler error in GCC.

[Darin Adler]

Comment on attachment 207591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207591&action=review

> Source/WebCore/rendering/RenderBlock.cpp:6771
> +        RenderTextFragment* remainingText = toRenderBoxModelObject(firstLetter)->firstLetterRemainingText();
>          if (remainingText) {

Would be nice to define this inside the if so there’s no worry about null dereference if we use it later.

[Andreas Kling]

Created attachment 208060 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 208060 [details]
Patch for landing

Clearing flags on attachment: 208060

Committed r153688: <http://trac.webkit.org/changeset/153688>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.