Bug 119181

Summary: RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*.
Product: WebKit Reporter: Andreas Kling <kling>
Component: Layout and RenderingAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
sam: review+, eflews.bot: commit-queue-
Patch for landing none

Description Andreas Kling 2013-07-27 15:44:23 PDT
RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*.
Comment 1 Andreas Kling 2013-07-27 15:56:33 PDT
Created attachment 207591 [details]
Patch
Comment 2 EFL EWS Bot 2013-07-27 16:11:26 PDT
Comment on attachment 207591 [details]
Patch

Attachment 207591 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1248574
Comment 3 Andreas Kling 2013-07-27 17:11:41 PDT
Comment on attachment 207591 [details]
Patch

Meh, the EFL EWS bot had some internal compiler error in GCC.
Comment 4 Darin Adler 2013-07-28 18:05:01 PDT
Comment on attachment 207591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207591&action=review

> Source/WebCore/rendering/RenderBlock.cpp:6771
> +        RenderTextFragment* remainingText = toRenderBoxModelObject(firstLetter)->firstLetterRemainingText();
>          if (remainingText) {

Would be nice to define this inside the if so there’s no worry about null dereference if we use it later.
Comment 5 Andreas Kling 2013-08-03 02:27:09 PDT
Created attachment 208060 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2013-08-03 03:14:02 PDT
Comment on attachment 208060 [details]
Patch for landing

Clearing flags on attachment: 208060

Committed r153688: <http://trac.webkit.org/changeset/153688>
Comment 7 WebKit Commit Bot 2013-08-03 03:14:05 PDT
All reviewed patches have been landed.  Closing bug.