Summary: | RenderBoxModelObject::firstLetterRemainingText should be a RenderTextFragment*. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andreas Kling <kling> | ||||||
Component: | Layout and Rendering | Assignee: | Andreas Kling <kling> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, eflews.bot, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Andreas Kling
2013-07-27 15:44:23 PDT
Created attachment 207591 [details]
Patch
Comment on attachment 207591 [details] Patch Attachment 207591 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1248574 Comment on attachment 207591 [details]
Patch
Meh, the EFL EWS bot had some internal compiler error in GCC.
Comment on attachment 207591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207591&action=review > Source/WebCore/rendering/RenderBlock.cpp:6771 > + RenderTextFragment* remainingText = toRenderBoxModelObject(firstLetter)->firstLetterRemainingText(); > if (remainingText) { Would be nice to define this inside the if so there’s no worry about null dereference if we use it later. Created attachment 208060 [details]
Patch for landing
Comment on attachment 208060 [details] Patch for landing Clearing flags on attachment: 208060 Committed r153688: <http://trac.webkit.org/changeset/153688> All reviewed patches have been landed. Closing bug. |