Bug 119177

Summary: EGL code needs to be made non-cairo specific
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Minor CC: bfulgham, buildbot, commit-queue, d-r, rniwa, sergio
Priority: P3    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Alex Christensen
Reported 2013-07-27 11:30:40 PDT
In order to get the AppleWin port to use EGL, the cairo-specific parts of it need to be protected by #if USE(CAIRO). After I do this, I'm going to move GLContext.h and GLContext.cpp from Source\WebCore\platform\graphics\cairo to Source\WebCore\platform\graphics, but I'll do that in a separate patch.
Attachments
Patch (3.08 KB, patch)
2013-07-27 11:38 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (495.06 KB, application/zip)
2013-07-27 17:37 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-27 11:38:37 PDT
Created attachment 207586 [details] Patch
Build Bot
Comment 2 2013-07-27 17:37:18 PDT
Comment on attachment 207586 [details] Patch Attachment 207586 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1254616 New failing tests: editing/selection/leak-document-with-selection-inside.html
Build Bot
Comment 3 2013-07-27 17:37:20 PDT
Created attachment 207594 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Brent Fulgham
Comment 4 2013-07-29 09:09:29 PDT
Comment on attachment 207586 [details] Patch r=me. This patch has nothing to do with any Mac WK2 test regressions. These files aren't even built on Mac.
WebKit Commit Bot
Comment 5 2013-07-29 09:33:35 PDT
Comment on attachment 207586 [details] Patch Clearing flags on attachment: 207586 Committed r153429: <http://trac.webkit.org/changeset/153429>
WebKit Commit Bot
Comment 6 2013-07-29 09:33:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.