Summary: | Allow new transitions to run even when controller is suspended | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||
Component: | CSS | Assignee: | Dean Jackson <dino> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, dstockwell, simon.fraser, thorton | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Dean Jackson
2013-07-26 17:14:19 PDT
Created attachment 207566 [details]
Patch
Comment on attachment 207566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207566&action=review > Source/WebCore/ChangeLog:21 > + (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Initialize new flag to false. > + (WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): Expose getter. > + (WebCore::AnimationControllerPrivate::setAllowNewAnimationsWhileSuspended): Expose setter. > + (WebCore::AnimationController::allowNewAnimationsWhileSuspended): "Public" getter. > + (WebCore::AnimationController::setAllowNewAnimationsWhileSuspended): "Public" setter. Are these up-to-date with the code changes? > Source/WebCore/page/animation/AnimationController.h:81 > + bool allowNewAnimationsWhileSuspended() const; > + void setAllowNewAnimationsWhileSuspended(bool); allow -> allows > Source/WebCore/page/animation/AnimationControllerPrivate.h:114 > + bool allowNewAnimationsWhileSuspended() const { return m_allowNewAnimationsWhileSuspended; } > + void setAllowNewAnimationsWhileSuspended(bool); allow -> allows > Source/WebCore/page/animation/AnimationControllerPrivate.h:148 > + bool m_allowNewAnimationsWhileSuspended; allows. might want to add a comment to explain why this is here. > Source/WebKit/mac/WebView/WebViewPrivate.h:568 > +- (BOOL)allowNewCSSAnimationsWhileSuspended; > +- (void)setAllowNewCSSAnimationsWhileSuspended:(BOOL)allowed; allows (In reply to comment #3) > (From update of attachment 207566 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=207566&action=review > > > Source/WebCore/ChangeLog:21 > > + (WebCore::AnimationControllerPrivate::AnimationControllerPrivate): Initialize new flag to false. > > + (WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended): Expose getter. > > + (WebCore::AnimationControllerPrivate::setAllowNewAnimationsWhileSuspended): Expose setter. > > + (WebCore::AnimationController::allowNewAnimationsWhileSuspended): "Public" getter. > > + (WebCore::AnimationController::setAllowNewAnimationsWhileSuspended): "Public" setter. > > Are these up-to-date with the code changes? Yes, other than a little error :) Made other changes as requested. Committed r153396: <http://trac.webkit.org/changeset/153396> |