Bug 119169

Summary:

RetainPtr should support ARC for Objective-C objects

Product:

WebKit

Reporter:

Mark Rowe (bdash) <mrowe>

Component:

Web Template Framework

Assignee:

Mark Rowe (bdash) <mrowe>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

andersca, benjamin, cmarcelo, commit-queue, eflews.bot, gtk-ews, gyuyoung.kim, mitz, rego+ews, webkit-ews, xan.lopez

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	eflews.bot: commit-queue-
Patch v2	andersca: review+

Description Mark Rowe (bdash) 2013-07-26 15:45:04 PDT

RetainPtr is not necessary when ARC is available, but it'll be easier to transition existing code to ARC if RetainPtr is compatible with it.

Comment 1 Mark Rowe (bdash) 2013-07-26 15:58:11 PDT

Created attachment 207560 [details]
Patch v1

Comment 2 WebKit Commit Bot 2013-07-26 15:59:51 PDT

Attachment 207560 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RetainPtr.h']" exit_code: 1
Source/WTF/wtf/RetainPtr.h:55:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WTF/wtf/RetainPtr.h:95:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WTF/wtf/RetainPtr.h:111:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WTF/wtf/RetainPtr.h:121:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 4 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 EFL EWS Bot 2013-07-26 16:05:46 PDT

Comment on attachment 207560 [details]
Patch v1

Attachment 207560 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1247335

Comment 4 Early Warning System Bot 2013-07-26 16:06:53 PDT

Comment on attachment 207560 [details]
Patch v1

Attachment 207560 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1250345

Comment 5 Early Warning System Bot 2013-07-26 16:07:01 PDT

Comment on attachment 207560 [details]
Patch v1

Attachment 207560 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1247336

Comment 6 kov's GTK+ EWS bot 2013-07-26 16:08:00 PDT

Comment on attachment 207560 [details]
Patch v1

Attachment 207560 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1254347

Comment 7 EFL EWS Bot 2013-07-26 16:13:12 PDT

Comment on attachment 207560 [details]
Patch v1

Attachment 207560 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1252324

Comment 8 Mark Rowe (bdash) 2013-07-26 16:21:36 PDT

Created attachment 207562 [details]
Patch v2

Updated to wrap the body of RetainPtr.h in an #if since it is only relevant for platforms that have CoreFoundation and/or Objective-C.

Comment 9 WebKit Commit Bot 2013-07-26 16:23:17 PDT

Attachment 207562 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WTF/ChangeLog', u'Source/WTF/wtf/RetainPtr.h']" exit_code: 1
Source/WTF/wtf/RetainPtr.h:99:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WTF/wtf/RetainPtr.h:115:  More than one command on the same line in if  [whitespace/parens] [4]
Source/WTF/wtf/RetainPtr.h:125:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 3 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 10 Mark Rowe (bdash) 2013-08-02 00:51:14 PDT

Landed in r153637.