Bug 119130
| Summary: | Redo the hit test in EventHandler::EventHandler if the node had been detached | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
| Component: | UI Events | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ap, benjamin, bfulgham, tonikitoo, wenson_hsieh |
| Priority: | P2 | Keywords: | BlinkMergeCandidate |
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Ryosuke Niwa
Consider merging https://chromium.googlesource.com/chromium/blink/+/f2696796968c131cf121536fd8c5f87d801d90a7
I think the patch is trying to fix the case where the target node had been detached from the document.
It makes sense for us to re-compute the target in such cases.
------Quoted text----
Changing selection by mouse click uses event target node to calculate position. This processing is performed after event dispatch. When event handler removes event target node, selection isn't changed.
This patch changes this behavior to pass recomputing event target when it is removed for changing selection.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ahmad Saleem
Took the test case from Chromium patch:
Link - https://jsfiddle.net/89tuLwr3/show
I am unable to reproduce the issue in Safari 15.6.1 and it behaves same as other browsers (Chrome Canary 107 and Firefox Nightly 105). Thanks!
Ryosuke Niwa
Chrome & WebKit behave the same and doesn't show blinking caret whereas Firefox does.
Ahmad Saleem
@Ryosuke - we now get 'caret' (blinking) in Safari 17. Do we need to do anything here?