Bug 119091

Summary:

Build fix (missing include in Source/JavaScriptCore/runtime/Structure.cpp)

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Build fix (add missing #include).	oliver: review+, commit-queue: commit-queue-

Julien Brianceau

Reported 2013-07-25 09:30:02 PDT

Seen with our bot: http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28070 /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/runtime/Structure.cpp: In member function 'void JSC::Structure::dumpInContext(WTF::PrintStream&, JSC::DumpContext*) const': /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/runtime/Structure.cpp:1040:16: error: invalid use of incomplete type 'struct JSC::DumpContext' /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/runtime/JSCJSValue.h:69:8: error: forward declaration of 'struct JSC::DumpContext' make[2]: *** [.obj/release-shared/runtime/Structure.o] Error 1

Attachments
Build fix (add missing #include). (985 bytes, patch) 2013-07-25 09:32 PDT, Julien Brianceau	oliver: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-07-25 09:32:12 PDT

Created attachment 207462 [details] Build fix (add missing #include).

WebKit Commit Bot

Comment 2 2013-07-25 10:13:00 PDT

Comment on attachment 207462 [details] Build fix (add missing #include). Rejecting attachment 207462 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 207462, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: 0-ab3c-d52691b4dbfc ... Currently at 153330 = 17694594c85756b9252b171aa484186d4fedf0ce r153331 = a7bbb1bba0b39267c86d73edd135e01014756b0b r153332 = 233cf8a5724076fda731782b4de0715c620f650f r153333 = 58304c96d373ba3ed977e57d446f28bbcbbce865 r153334 = a745e206eb79eb857257745596d9f37c5f816c76 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.appspot.com/results/1218190

Julien Brianceau

Comment 3 2013-07-26 13:47:31 PDT

Already fixed in r153334: http://trac.webkit.org/changeset/153334

Note You need to log in before you can comment on or make changes to this bug.