Bug 11908
| Summary: | WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Eric Seidel (no email) <eric> |
| Component: | SVG | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | mitz |
| Priority: | P2 | ||
| Version: | 420+ | ||
| Hardware: | Mac | ||
| OS: | OS X 10.4 | ||
| URL: | http://xml2.mweb.co.za/clipart/plants/bamboo_01.svg | ||
| Bug Depends on: | 11108 | ||
| Bug Blocks: | |||
Eric Seidel (no email)
WebKit spends 40% of its time displaying "bamboo.svg" executing Regexes
This function:
bool SVGTransformable::parseTransformAttribute(SVGTransformList* list, const AtomicString& transform)
Uses a regex for parsing. Ick.
that's eating 40% of our time while parsing, at least when displaying bamboo.svg I think a simpler, custom parser is in order.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
it's actually bamboo_01.svg
http://xml2.mweb.co.za/clipart/plants/bamboo_01.svg
Save it locally for proper testing.
mitz
(In reply to comment #0)
> I think a simpler, custom parser is in order.
See attachment 10944 [details] in bug 11108.
Rob Buis
Hi Eric, Mitz,
(In reply to comment #2)
> (In reply to comment #0)
>
> > I think a simpler, custom parser is in order.
>
> See attachment 10944 [details] [edit] in bug 11108.
I created a new patch that actually compiles on ToT :) I'd love it if someone could take it and shark it with bamboo.svg, since I am away for at least 24h.
Cheers,
Rob.
Rob Buis
Landed in r18440.
Rob Buis
Landed in r18440.