Bug 119079

Summary:

[sh4] Add missing implementation of in bxxxnz in LLINT

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fpizlo, oliver

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Missing implementation of bxxxnz in sh4 backend for LLINT.	none

Julien Brianceau

Reported 2013-07-25 04:32:07 PDT

Fix sh4 backend build: offlineasm: Parsing /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h. offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/ast.rb:829:in `lowerDefault': Unhandled opcode bsubinz at /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:329At /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:329 (RuntimeError) from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/sh4.rb:780:in `lowerSH4' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[2]: *** [generated/./LLIntAssembly.h] Error 1

Attachments
Missing implementation of bxxxnz in sh4 backend for LLINT. (1.43 KB, patch) 2013-07-25 04:34 PDT, Julien Brianceau	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-07-25 04:34:45 PDT

Created attachment 207448 [details] Missing implementation of bxxxnz in sh4 backend for LLINT.

WebKit Commit Bot

Comment 2 2013-07-25 05:28:13 PDT

Comment on attachment 207448 [details] Missing implementation of bxxxnz in sh4 backend for LLINT. Clearing flags on attachment: 207448 Committed r153317: <http://trac.webkit.org/changeset/153317>

WebKit Commit Bot

Comment 3 2013-07-25 05:28:14 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.