Bug 119076

Summary:

[sh4][mips] Fix "Unhandled opcode localAnnotation" build error in LLINT

Product:

WebKit

Reporter:

Julien Brianceau <jbriance>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

barraclough, commit-queue, fpizlo, kilvadyb, oliver, ossy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Build fix for sh4 and mips llint.	none
Build fix for sh4 and mips llint (the right one).	none

Julien Brianceau

Reported 2013-07-25 01:22:04 PDT

Build error since ~ r153296: sh4 build bot (http://build.webkit.org/builders/Qt%20Linux%20SH4%20Release/builds/28043): offlineasm: Parsing /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h. offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/sh4.rb:780:in `lowerSH4': Unhandled opcode localAnnotation at /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:318At /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:318 (RuntimeError) from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /local/wkit/slavebuildbot_LOCAL/workspace_LOCAL/qt-linux-sh4-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[2]: *** [generated/./LLIntAssembly.h] Error 1 mips build bot (http://build.webkit.org/builders/Qt%20Linux%20MIPS32R2%20LE%20Release/builds/16798): offlineasm: Parsing /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and LLIntOffsetsExtractor and creating assembly file generated/LLIntAssembly.h. offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm offlineasm: Including file /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/mips.rb:889:in `lowerMIPS': Unhandled opcode localAnnotation at /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:318At /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:318 (RuntimeError) from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:67:in `lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:119:in `block in lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `each' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/backends.rb:117:in `lower' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:271:in `block (5 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:65:in `inAsm' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:270:in `block (4 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:182:in `emitCodeInConfiguration' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:269:in `block (3 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/settings.rb:89:in `forSettings' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:265:in `block (2 levels) in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `each' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:261:in `block in <main>' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `open' from /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/JavaScriptCore/offlineasm/asm.rb:252:in `<main>' make[3]: *** [generated/./LLIntAssembly.h] Error 1

Attachments
Build fix for sh4 and mips llint. (1.49 KB, patch) 2013-07-25 01:26 PDT, Julien Brianceau	no flags	Details Formatted Diff Diff
Build fix for sh4 and mips llint (the right one). (1.63 KB, patch) 2013-07-25 01:52 PDT, Julien Brianceau	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Julien Brianceau

Comment 1 2013-07-25 01:26:11 PDT

Created attachment 207438 [details] Build fix for sh4 and mips llint.

Julien Brianceau

Comment 2 2013-07-25 01:43:09 PDT

Comment on attachment 207438 [details] Build fix for sh4 and mips llint. Wrong fix

Julien Brianceau

Comment 3 2013-07-25 01:52:41 PDT

Created attachment 207440 [details] Build fix for sh4 and mips llint (the right one). Better with the right fix.

WebKit Commit Bot

Comment 4 2013-07-25 03:23:07 PDT

Comment on attachment 207440 [details] Build fix for sh4 and mips llint (the right one). Clearing flags on attachment: 207440 Committed r153307: <http://trac.webkit.org/changeset/153307>

WebKit Commit Bot

Comment 5 2013-07-25 03:23:09 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.