Bug 119037

Summary:

Build fails with EGLConfigSelector.cpp when OpenGL ES is not used

Product:

WebKit

Reporter:

Donggwan Kim <donggwan.kim>

Component:

Platform

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarcelo, commit-queue, luiz, noam, zeno

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

Linux

Attachments:

Description	Flags
Patch	none

Donggwan Kim

Reported 2013-07-24 00:55:53 PDT

Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: In member function void* WebCore::EGLConfigSelector::createConfig(EGLint): Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:5: error: expected unqualified-id before for Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:21: error: i was not declared in this scope Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:119:40: error: expected ; before ) token Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:107:15: warning: unused variable config [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:12: warning: unused variable alpha [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:19: warning: unused variable surface [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:28: warning: unused variable red [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:33: warning: unused variable green [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:40: warning: unused variable blue [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:108:46: warning: unused variable renderType [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:109:12: warning: unused variable expectedAlpha [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:110:12: warning: unused variable expectedRed [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:111:12: warning: unused variable expectedBlue [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:112:12: warning: unused variable expectedGreen [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:116:12: warning: unused variable expectedRenderType [-Wunused-variable] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: error: expected } at end of input Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: At global scope: Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:85:11: warning: unused parameter expectedSurfaceType [-Wunused-parameter] Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: error: expected } at end of input Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp: In member function void* WebCore::EGLConfigSelector::createConfig(EGLint): Source/WebCore/platform/graphics/surfaces/egl/EGLConfigSelector.cpp:228:1: warning: control reaches end of non-void function [-Wreturn-type] make[2]: *** [Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/surfaces/egl/EGLConfigSelector.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... [ 11%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/CSSGrammar.cpp.o make[1]: *** [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2 make: *** [all] Error 2

Attachments
Patch (1.56 KB, patch) 2013-07-24 00:59 PDT, Donggwan Kim	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Donggwan Kim

Comment 1 2013-07-24 00:59:46 PDT

Created attachment 207379 [details] Patch

Brent Fulgham

Comment 2 2013-10-30 11:34:47 PDT

Comment on attachment 207379 [details] Patch r=me

WebKit Commit Bot

Comment 3 2013-10-30 12:05:59 PDT

Comment on attachment 207379 [details] Patch Clearing flags on attachment: 207379 Committed r158300: <http://trac.webkit.org/changeset/158300>

WebKit Commit Bot

Comment 4 2013-10-30 12:06:02 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.