Bug 118941 – Do not allocate 2 AtomicString just to do a comparison in HTMLAnchorElement::setRel()

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

Do not allocate 2 AtomicString just to do a comparison in HTMLAnchorElement::setRel()

[Benjamin Poulain]

Created attachment 207189 [details]
Patch

[Gavin Barraclough]

Comment on attachment 207189 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207189&action=review

> Source/WebCore/dom/SpaceSplitString.h:91
> +            return spaceSplitStringContainsValue(spaceSplitString, value, length - 1, shouldFoldCase);

The -1 here wasn't obvious to me?

[Benjamin Poulain]

(In reply to comment #2)
> (From update of attachment 207189 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207189&action=review
> 
> > Source/WebCore/dom/SpaceSplitString.h:91
> > +            return spaceSplitStringContainsValue(spaceSplitString, value, length - 1, shouldFoldCase);
> 
> The -1 here wasn't obvious to me?

It is because the length of the array for a string literal include the ending zero.

"Foo" -> evaluates to 4.

[Benjamin Poulain]

Committed r153005: <http://trac.webkit.org/changeset/153005>