Bug 118926 – ANGLE does not compile with code coverage analysis

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Alex Christensen]

There is an exception in build-webkit that prevents ANGLE from being built for code coverage analysis, and generate-coverage-data rebuilds JavaScriptCore.  This is part of my improvements to code coverage analysis.

[Alex Christensen]

Created attachment 207156 [details]
Patch

[Tim Horton]

Comment on attachment 207156 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review

> Tools/ChangeLog:10
> +        * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
> +        * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
> +        (generateReport): Moved report generation to a subroutine.

You did things that you didn’t mention here.

> Tools/Scripts/build-webkit:-329
> -        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";

Do you know historically where this came from? it seems surprisingly specific.

> Tools/Scripts/generate-coverage-data:61
> +system("Tools/Scripts/run-javascriptcore-tests --no-build");

why just —no-build for jsc tests? I think most of the others support that too.

[Build Bot]

Comment on attachment 207156 [details]
Patch

Attachment 207156 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1105967

New failing tests:
editing/pasteboard/4641033.html

[Build Bot]

Created attachment 207158 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Alex Christensen]

(In reply to comment #2)
> (From update of attachment 207156 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review
> 
> > Tools/ChangeLog:10
> > +        * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
> > +        * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
> > +        (generateReport): Moved report generation to a subroutine.
> 
> You did things that you didn’t mention here.
Those were the only functional changes.  Removing useless comments wasn't worth mentioning.
> 
> > Tools/Scripts/build-webkit:-329
> > -        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";
> 
> Do you know historically where this came from? it seems surprisingly specific.
> 
> > Tools/Scripts/generate-coverage-data:61
> > +system("Tools/Scripts/run-javascriptcore-tests --no-build");
> 
> why just —no-build for jsc tests? I think most of the others support that too.
The other scripts don't build by default.

I'm going to cq+ this even though mac-wk2 doesn't like it.  Nobody uses this script yet.  There is no way this broke anything.

[Alex Christensen]

> Do you know historically where this came from? it seems surprisingly specific.

I don't.  Test coverage works with ANGLE.  Maybe someone didn't want ANGLE's lack of coverage to taint the results, but that's not a problem right now.

[Tim Horton]

(In reply to comment #5)
> (In reply to comment #2)
> > (From update of attachment 207156 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=207156&action=review
> > 
> > > Tools/ChangeLog:10
> > > +        * Scripts/build-webkit: Removed exception preventing ANGLE code coverage support.
> > > +        * Scripts/generate-coverage-data: Added --no-build to run-javascriptcore-tests call.
> > > +        (generateReport): Moved report generation to a subroutine.
> > 
> > You did things that you didn’t mention here.
> Those were the only functional changes.  Removing useless comments wasn't worth mentioning.

Adding --release was a functional change :D

> > > Tools/Scripts/build-webkit:-329
> > > -        push @local_options, XcodeCoverageSupportOptions() if $coverageSupport && $project ne "ANGLE";
> > 
> > Do you know historically where this came from? it seems surprisingly specific.
> > 
> > > Tools/Scripts/generate-coverage-data:61
> > > +system("Tools/Scripts/run-javascriptcore-tests --no-build");
> > 
> > why just —no-build for jsc tests? I think most of the others support that too.
> The other scripts don't build by default.

I don't think that's true. It's certainly not true for run-api-tests. I'm pretty sure run-webkit-tests will build some things as well.

> I'm going to cq+ this even though mac-wk2 doesn't like it.  Nobody uses this script yet.  There is no way this broke anything.

[WebKit Commit Bot]

Comment on attachment 207156 [details]
Patch

Clearing flags on attachment: 207156

Committed r152934: <http://trac.webkit.org/changeset/152934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alex Christensen]

(In reply to comment #7)
> Adding --release was a functional change :D
You're right.  I need to be more careful in my changelogs.

> I don't think that's true. It's certainly not true for run-api-tests. I'm pretty sure run-webkit-tests will build some things as well.
run-javascriptcore-tests was rebuilding all of JavaScriptCore.  I should look into the others.