Bug 118882 – [EFL][WK2] test of ewk_context_new failed in test_ewk2_context

• Component: WebKit2
• Status: RESOLVED LATER

[Donggwan Kim]

ASSERTION FAILED: !result
/Source/WTF/wtf/ThreadingPthreads.cpp(344) : void WTF::Mutex::lock()
1   0x7ffe433017b8 WTFCrash
2   0x7ffe4333345d WTF::Mutex::lock()
3   0x7ffe42f361f2 WTF::Locker<WTF::Mutex>::Locker(WTF::Mutex&)
4   0x7ffe42470e6e WorkQueue::performWork()
5   0x7ffe4247156c WorkQueue::workQueueThread(WorkQueue*)
6   0x7ffe433112f1
7   0x7ffe43332d88
8   0x7ffe417a7e9a
9   0x7ffe40fbeccd clone
Segmentation fault (core dumped)

[Sergio Correia (qrwteyrutiyoup)]

Byungwoo has fixed some problems with the WorkQueue in https://bugs.webkit.org/show_bug.cgi?id=115332, still under review. With his patch applied, this crash goes away, although we still get the following message:

Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:330 ewk_context_additional_plugin_path_set() safety check failed: path == NULL

Let's get Chris to take another look at that patch :)

[Donggwan Kim]

I will check this bug again after it is fixed.

[Chris Dumez]

(In reply to comment #1)
> Byungwoo has fixed some problems with the WorkQueue in https://bugs.webkit.org/show_bug.cgi?id=115332, still under review. With his patch applied, this crash goes away, although we still get the following message:
> 
> Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:330 ewk_context_additional_plugin_path_set() safety check failed: path == NULL
> 
> Let's get Chris to take another look at that patch :)

As I said earlier, an owner needs to sign off on it before I can review because the patch is touching generic wk2 files.

[Sergio Correia (qrwteyrutiyoup)]

(In reply to comment #3)
> (In reply to comment #1)
> > Byungwoo has fixed some problems with the WorkQueue in https://bugs.webkit.org/show_bug.cgi?id=115332, still under review. With his patch applied, this crash goes away, although we still get the following message:
> > 
> > Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:330 ewk_context_additional_plugin_path_set() safety check failed: path == NULL
> > 
> > Let's get Chris to take another look at that patch :)
> 
> As I said earlier, an owner needs to sign off on it before I can review because the patch is touching generic wk2 files.

Ah, I see. Apologies, then. I saw your comment in the other bug, but I was under the impression a reviewer would need to do some kind of informal review and then an owner would sign it off :)