Bug 118827

Summary: [gstreamer] Avoid calls to g_slist_index in webKitWebAudioSrcLoop()
Product: WebKit Reporter: Nick Diego Yamane (diegoyam) <nick.diego>
Component: Web AudioAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, crogers, eric.carlson, glenn, jer.noble, pnormand
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Improved changelog.
none
Patch none

Nick Diego Yamane (diegoyam)
Reported 2013-07-17 20:19:57 PDT
[gstreamer] Avoid calls to g_slist_index in webKitWebAudioSrcLoop()
Attachments
Patch (3.33 KB, patch)
2013-07-17 20:27 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Improved changelog. (3.31 KB, patch)
2013-07-17 20:44 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Patch (3.31 KB, patch)
2013-07-17 21:04 PDT, Nick Diego Yamane (diegoyam) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Nick Diego Yamane (diegoyam)
Comment 1 2013-07-17 20:24:28 PDT
webKitWebAudioSrcLoop() currently calls g_slist_index for each element to get its index in a list it's iterating over. g_list_index function uses a sequential search to find that element, which is clearly unecessary. This patch adds a local variable to store the current index and use it instead of calling g_slist_index funtion.
Nick Diego Yamane (diegoyam)
Comment 2 2013-07-17 20:27:02 PDT
Created attachment 206944 [details] Patch
Nick Diego Yamane (diegoyam)
Comment 3 2013-07-17 20:44:04 PDT
Created attachment 206945 [details] Improved changelog.
Nick Diego Yamane (diegoyam)
Comment 4 2013-07-17 21:04:50 PDT
Created attachment 206946 [details] Patch Fixing typo.
Philippe Normand
Comment 5 2013-07-17 23:54:07 PDT
Comment on attachment 206946 [details] Patch Looks good, thanks!
WebKit Commit Bot
Comment 6 2013-07-18 00:26:08 PDT
Comment on attachment 206946 [details] Patch Clearing flags on attachment: 206946 Committed r152832: <http://trac.webkit.org/changeset/152832>
WebKit Commit Bot
Comment 7 2013-07-18 00:26:10 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.