Bug 118825

Summary: [cairo] crash with large accelerated canvas
Product: WebKit Reporter: arno. <a.renevier>
Component: CanvasAssignee: arno. <a.renevier>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: a.renevier, commit-queue, d-r, mrobinson, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://renevier.net/tmp/large-canvas.html
Attachments:
Description Flags
patch proposal mrobinson: review-

arno.
Reported 2013-07-17 18:00:16 PDT
Hi, when there is a large accelerated canvas (with a dimension larger than GL_MAX_RENDERBUFFER_SIZE) actually, webkit web process crashes by triggering the following cairo assertion: cairo-gl-surface.c:407: _cairo_gl_surface_create_scratch_for_texture: Assertion `width <= ctx->max_framebuffer_size && height <= ctx->max_framebuffer_size' failed. See testcase (GL_MAX_RENDERBUFFER_SIZE is 8192 on my system)
Attachments
patch proposal (2.69 KB, patch)
2013-07-18 12:00 PDT, arno. 		mrobinson: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
arno.
Comment 1 2013-07-18 12:00:41 PDT
Created attachment 207009 [details] patch proposal
Martin Robinson
Comment 2 2013-07-19 08:51:33 PDT
Comment on attachment 207009 [details] patch proposal We should see if this is fixable in Cairo. I'll check today.
Martin Robinson
Comment 3 2016-03-09 18:39:37 PST
I'm not able to get it to display properly, but it seems like Cairo no longer asserts in this case. Instead it creates an error surface, as one would expect. Given that I think this patch is no longer necessary. Arno, if you still think it is, feel free to respond and we can get this going again. I'm really sorry it took me so long to review this.
Note You need to log in before you can comment on or make changes to this bug.