Patterns on fill/stroke of text doesn't work

• Component: SVG
• Status: RESOLVED FIXED

[Nikolas Zimmermann]

A subtle bug in SVGPatternElement and two wrong calls in SVGPaintServerPatternCg, currently prevent that to work. Attaching patch soon.

[Nikolas Zimmermann]

Created attachment 11918 [details]
Initial patch

Here's a screenshot showing pattern on stroke/fill of text:
http://www.flickr.com/photos/43532360@N00/327436697/

[Oliver Hunt]

Comment on attachment 11918 [details]
Initial patch

In

-    if (!m_paintServer || !m_paintServer->activeClient() || m_ignoreAttributeChanges)
+    if (ownerDocument()->parsing() || !attached() || !m_paintServer || m_ignoreAttributeChanges)

Move the pure bool checks to the beginning of the condition

[Nikolas Zimmermann]

Created attachment 11919 [details]
Updated patch

Fix Oliver's issue.

[Oliver Hunt]

Comment on attachment 11919 [details]
Updated patch

Fix indentation of + if (isPaintingText()) 

then it's landable

-        if (isPaintingText()) {
-            const_cast<RenderObject*>(object)->style()->setColor(Color());
+ 
+       if (isPaintingText()) 
             context->setTextDrawingMode(cTextFill);
-        }
     }

[Nikolas Zimmermann]

Landed in r18322.