Bug 118776

Summary:

Only the first call to 'stop' method of AudioBufferSourceNode must be entertained.

Product:

WebKit

Reporter:

Praveen Jadhav <praveen.j>

Component:

Web Audio

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, crogers, dev_sachin, eric.carlson, glenn, jer.noble, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2	none
Patch	none

Description Praveen Jadhav 2013-07-16 21:37:51 PDT

'stop' method should be called only once for an AudioBufferSourceNode (and OscillatorNode). Any further call to 'stop' method for the same source must throw an exception. In the current implementation, further calls to 'stop' method before the node goes to FINISHED_STATE updates the end time of the node which is not as expected.

Comment 1 Praveen Jadhav 2013-07-16 21:54:36 PDT

Created attachment 206852 [details]
Patch

Comment 2 Build Bot 2013-07-17 00:36:45 PDT

Comment on attachment 206852 [details]
Patch

Attachment 206852 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1102110

New failing tests:
fullscreen/full-screen-iframe-with-max-width-height.html

Comment 3 Build Bot 2013-07-17 00:36:46 PDT

Created attachment 206863 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

Comment 4 Praveen Jadhav 2013-07-18 01:47:46 PDT

Created attachment 206968 [details]
Patch

Comment 5 WebKit Commit Bot 2013-07-18 08:38:06 PDT

Comment on attachment 206968 [details]
Patch

Clearing flags on attachment: 206968

Committed r152846: <http://trac.webkit.org/changeset/152846>

Comment 6 WebKit Commit Bot 2013-07-18 08:38:08 PDT

All reviewed patches have been landed.  Closing bug.