Bug 118770

Summary:

setPluginUnavailabilityReason can destroy renderObject before obscurity check

Product:

WebKit

Reporter:

Gordon Sheridan <gordon_sheridan>

Component:

Plug-ins

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac (Intel)

OS:

OS X 10.8

Attachments:

Description	Flags
Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason().	none

Gordon Sheridan

Reported 2013-07-16 21:03:49 PDT

When creating a replacement object for blocked plugins, setPluginUnavailabilityReason can destroy the renderObject, so we need to call renderObject->isReplacementObscured() beforehand.

Attachments
Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason(). (3.04 KB, patch) 2013-07-16 21:15 PDT, Gordon Sheridan	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Gordon Sheridan

Comment 1 2013-07-16 21:15:38 PDT

Created attachment 206844 [details] Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason().

WebKit Commit Bot

Comment 2 2013-07-16 23:02:48 PDT

Comment on attachment 206844 [details] Patch to move the obscurity check for blocked plugin replacements before calling setPluginUnavailabilityReason(). Clearing flags on attachment: 206844 Committed r152756: <http://trac.webkit.org/changeset/152756>

WebKit Commit Bot

Comment 3 2013-07-16 23:02:50 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.