Bug 118768

Summary: Remove a bunch of redundant checks for empty string in StringImpl
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch rniwa: review+

Benjamin Poulain
Reported 2013-07-16 20:50:54 PDT
Remove a bunch of redundant checks for empty string in StringImpl
Attachments
Patch (7.25 KB, patch)
2013-07-16 21:40 PDT, Benjamin Poulain 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2013-07-16 21:40:33 PDT
Created attachment 206850 [details] Patch
Ryosuke Niwa
Comment 2 2013-08-01 21:06:44 PDT
Comment on attachment 206850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206850&action=review > Source/WTF/wtf/text/StringImpl.cpp:416 > int32_t length = m_length; Can we add an assertion that m_length is non-zero here? > Source/WTF/wtf/text/StringImpl.cpp:448 > Ditto.
Benjamin Poulain
Comment 3 2013-08-02 20:32:17 PDT
Committed r153686: <http://trac.webkit.org/changeset/153686>
Note You need to log in before you can comment on or make changes to this bug.