Summary: | Remove a bunch of redundant checks for empty string in StringImpl | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cmarcelo, commit-queue | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Benjamin Poulain
2013-07-16 20:50:54 PDT
Created attachment 206850 [details]
Patch
Comment on attachment 206850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=206850&action=review > Source/WTF/wtf/text/StringImpl.cpp:416 > int32_t length = m_length; Can we add an assertion that m_length is non-zero here? > Source/WTF/wtf/text/StringImpl.cpp:448 > Ditto. Committed r153686: <http://trac.webkit.org/changeset/153686> |