Bug 118755

Summary: check-webkit-style: "using namespace foo;" should be flagged as an error only in headers
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: Tools / TestsAssignee: Kwang Yul Seo <skyul>
Status: RESOLVED FIXED    
Severity: Normal CC: brian.holt, commit-queue, dpranke, glenn, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2013-07-16 16:44:27 PDT
The patch in Bug 57241 is buggy because it flags "using namespace foo;" in source files too.
Attachments
Patch (3.54 KB, patch)
2013-07-16 16:51 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2013-07-16 16:51:03 PDT
Created attachment 206827 [details] Patch
Kwang Yul Seo
Comment 2 2013-07-16 17:11:05 PDT
Comment on attachment 206827 [details] Patch Clearing flags on attachment: 206827 Committed r152748: <http://trac.webkit.org/changeset/152748>
Kwang Yul Seo
Comment 3 2013-07-16 17:11:09 PDT
All reviewed patches have been landed. Closing bug.
Brian Holt
Comment 4 2013-07-17 02:10:54 PDT
Good catch! I didn't realise from the original bug that it was only meant to apply to headers.
Note You need to log in before you can comment on or make changes to this bug.