Bug 118754

Summary:

AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Accessibility

Assignee:

James Craig <jcraig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, apinheiro, buildbot, cfleizach, commit-queue, dmazzoni, jdiggs, mario, rniwa, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

119988

Attachments:

Description	Flags
patch	darin: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2	none
patch with review feedback IDREF changes	none

Description James Craig 2013-07-16 16:27:28 PDT

AX: aria-required.html needs to test @required vs @aria-required mismatch reconciliation
LayoutTests/accessibility/aria-required.html

The readonly test provides more coverage of the @readonly vs @aria-readonly mismatch reconciliation. Update the @required one to match.
LayoutTests/accessibility/aria-readonly.html

Comment 1 Radar WebKit Bug Importer 2013-07-16 16:27:57 PDT

<rdar://problem/14462302>

Comment 2 James Craig 2013-08-18 17:59:03 PDT

Created attachment 209044 [details]
patch

Comment 3 Darin Adler 2013-08-18 19:37:23 PDT

Comment on attachment 209044 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209044&action=review

> LayoutTests/accessibility/aria-required-expected.txt:8
> +PASS textfield1 isRequired is false

This is an improvement, but this test is sill deficient. Normally we try to put as much as possible in the expressions that are logged to make clear what's being tested, choosing names that express what's going on. The names here do not make it clear enough what is being tested, so the test output is sufficiently readable. There is nothing here that helps me understand why "textfield1" should not be required, but textfield2 should be.

Comment 4 Build Bot 2013-08-18 22:08:46 PDT

Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1502610

New failing tests:
accessibility/aria-required.html

Comment 5 Build Bot 2013-08-18 22:08:49 PDT

Created attachment 209054 [details]
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-04  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

Comment 6 Build Bot 2013-08-19 07:40:24 PDT

Comment on attachment 209044 [details]
patch

Attachment 209044 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1518204

New failing tests:
accessibility/aria-required.html

Comment 7 Build Bot 2013-08-19 07:40:27 PDT

Created attachment 209086 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4

Comment 8 James Craig 2013-08-19 08:35:04 PDT

Created attachment 209091 [details]
patch with review feedback IDREF changes

Comment 9 WebKit Commit Bot 2013-08-19 17:51:58 PDT

Comment on attachment 209091 [details]
patch with review feedback IDREF changes

Clearing flags on attachment: 209091

Committed r154309: <http://trac.webkit.org/changeset/154309>

Comment 10 WebKit Commit Bot 2013-08-19 17:52:01 PDT

All reviewed patches have been landed.  Closing bug.