Bug 118696

Summary:

WebGL tests should be enabled on Mac

Product:

WebKit

Reporter:

Alex Christensen <achristensen>

Component:

WebGL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Major

CC:

buildbot, commit-queue, dino, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

OS X 10.8

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion	none
Patch	none

Alex Christensen

Reported 2013-07-15 17:55:42 PDT

Ever since r142847, all WebGL tests have been disabled on Mac. There are only 32 tests that fail, and the rest pass. I think the other 514 passing tests should be enabled so we can tell if we break something.

Attachments
Patch (8.30 KB, patch) 2013-07-15 17:56 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-02 for mac-mountainlion (843.72 KB, application/zip) 2013-07-15 22:02 PDT, WebKit Commit Bot	no flags	Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (622.75 KB, application/zip) 2013-07-15 22:26 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (726.94 KB, application/zip) 2013-07-16 02:58 PDT, Build Bot	no flags	Details
Patch (8.69 KB, patch) 2013-07-16 09:59 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2013-07-15 17:56:48 PDT

Created attachment 206710 [details] Patch

WebKit Commit Bot

Comment 2 2013-07-15 22:02:40 PDT

Comment on attachment 206710 [details] Patch Rejecting attachment 206710 [details] from commit-queue. New failing tests: webgl/conformance/limits/gl-max-texture-dimensions.html webgl/conformance/glsl/variables/gl-pointcoord.html webgl/conformance/rendering/more-than-65536-indices.html webgl/conformance/textures/texture-size.html Full output: http://webkit-queues.appspot.com/results/1088054

WebKit Commit Bot

Comment 3 2013-07-15 22:02:42 PDT

Created attachment 206722 [details] Archive of layout-test-results from webkit-cq-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-02 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Build Bot

Comment 4 2013-07-15 22:26:42 PDT

Comment on attachment 206710 [details] Patch Attachment 206710 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1080092 New failing tests: webgl/conformance/limits/gl-max-texture-dimensions.html webgl/conformance/glsl/variables/gl-pointcoord.html webgl/conformance/rendering/more-than-65536-indices.html webgl/conformance/textures/texture-size.html

Build Bot

Comment 5 2013-07-15 22:26:43 PDT

Created attachment 206723 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.3

Build Bot

Comment 6 2013-07-16 02:58:24 PDT

Comment on attachment 206710 [details] Patch Attachment 206710 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1087117 New failing tests: webgl/conformance/rendering/multisample-corruption.html webgl/conformance/limits/gl-max-texture-dimensions.html webgl/conformance/glsl/variables/gl-pointcoord.html webgl/conformance/textures/texture-size.html webgl/conformance/glsl/functions/glsl-function-smoothstep-gentype.html webgl/conformance/ogles/GL/operators/operators_009_to_016.html

Build Bot

Comment 7 2013-07-16 02:58:26 PDT

Created attachment 206747 [details] Archive of layout-test-results from webkit-ews-01 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.3

Alex Christensen

Comment 8 2013-07-16 09:59:29 PDT

Created attachment 206792 [details] Patch

WebKit Commit Bot

Comment 9 2013-07-16 15:55:54 PDT

Comment on attachment 206792 [details] Patch Clearing flags on attachment: 206792 Committed r152746: <http://trac.webkit.org/changeset/152746>

WebKit Commit Bot

Comment 10 2013-07-16 15:55:57 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.