Bug 11869

Summary: scroll wheel events are ignored by all iframes
Product: WebKit Reporter: Dex Deacon <occupant4>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, hyatt
Priority: P2    
Version: 420+   
Hardware: PC   
OS: Windows XP   
URL: http://www.nicky.net/4images/iframe.html
Attachments:
Description Flags
make iframes accept scroll wheel events mjs: review+

Dex Deacon
Reported 2006-12-18 15:54:23 PST
RenderPartObject::viewCleared() sets the m_ignoreWheelEvents flag on a view's EventHandler object for all iframes. This code looks pretty ancient, but the m_ignoreWheelEvents flag has been ignored up until recently; now iframe scrolling via the mouse wheel doesn't work. I think this is incorrect. I'll attach a patch to remove the offending line.
Attachments
make iframes accept scroll wheel events (1.04 KB, patch)
2006-12-18 15:58 PST, Dex Deacon 		mjs: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dex Deacon
Comment 1 2006-12-18 15:58:52 PST
Created attachment 11911 [details] make iframes accept scroll wheel events
Darin Adler
Comment 2 2006-12-18 20:26:45 PST
Is anyone using m_ignoreWheelEvents for any purpose?
Dex Deacon
Comment 3 2006-12-19 11:34:28 PST
(In reply to comment #2) > Is anyone using m_ignoreWheelEvents for any purpose? From what I can tell, it's only ever used by this code that sets it for all iframes.
Maciej Stachowiak
Comment 4 2006-12-29 00:34:57 PST
I think hyatt should look at this.
Dave Hyatt
Comment 5 2006-12-29 00:58:15 PST
Need more information. Who uses this flag? Is it used on Mac?
Dex Deacon
Comment 6 2007-01-03 17:22:08 PST
The only time setIgnoreWheelEvents() is called in the code is in RenderPartObject::viewCleared(). The only code that checks m_ignoreWheelEvents is in EventHandler::handleWheelEvent() (which early-outs if it is set).
Maciej Stachowiak
Comment 7 2007-01-19 16:46:52 PST
Comment on attachment 11911 [details] make iframes accept scroll wheel events r=me
Maciej Stachowiak
Comment 8 2007-01-19 16:47:37 PST
Hyatt landed this. Thanks for the fix!
Note You need to log in before you can comment on or make changes to this bug.