Bug 118669

Summary: Text with "text-overflow:ellipsis" and an SVG font do not render correctly
Product: WebKit Reporter: Antoine Quint <graouts>
Component: Layout and RenderingAssignee: Antoine Quint <graouts>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, ddkilzer, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Updated patch with test explicitly turning on kerning and ligatures.
ddkilzer: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion none

Antoine Quint
Reported 2013-07-15 05:38:08 PDT
The test at LayoutTests/svg/text/text-overflow-ellipsis-svgfont.html is an illustration of this, it just renders blank instead of glyphs before the ellipsis, and in some cases, such as on m.simon.com's search page, it draws garbage instead of text, even though in both cases, selecting the text and copying has the correct text in the clipboard. Interestingly enough, the layout test's ref image in platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.png has the correct rendering and running this test with pixel-results enabled passes anyway…
Attachments
Patch (3.27 KB, patch)
2013-07-15 05:46 PDT, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Updated patch with test explicitly turning on kerning and ligatures. (30.36 KB, patch)
2013-07-15 07:42 PDT, Antoine Quint 		ddkilzer: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (543.73 KB, application/zip)
2013-07-15 09:51 PDT, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-07-15 05:38:37 PDT
<rdar://problem/14442444>
Antoine Quint
Comment 2 2013-07-15 05:46:15 PDT
Created attachment 206657 [details] Patch
Antoine Quint
Comment 3 2013-07-15 07:19:24 PDT
The likely reason why DRT doesn't pick up on the failure before this patch is that kerning and ligatures are turned off: http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm#L656
Antoine Quint
Comment 4 2013-07-15 07:42:19 PDT
Created attachment 206662 [details] Updated patch with test explicitly turning on kerning and ligatures.
Build Bot
Comment 5 2013-07-15 09:51:50 PDT
Comment on attachment 206662 [details] Updated patch with test explicitly turning on kerning and ligatures. Attachment 206662 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1074150 New failing tests: fullscreen/full-screen-iframe-with-max-width-height.html
Build Bot
Comment 6 2013-07-15 09:51:52 PDT
Created attachment 206671 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.3
Antoine Quint
Comment 7 2013-07-15 10:43:20 PDT
The test at fullscreen/full-screen-iframe-with-max-width-height.html passes fine on 10.9, not sure what could be specifically wrong about Mountain Lion and this patch…
David Kilzer (:ddkilzer)
Comment 8 2013-07-15 12:05:03 PDT
Comment on attachment 206662 [details] Updated patch with test explicitly turning on kerning and ligatures. r=me
David Kilzer (:ddkilzer)
Comment 9 2013-07-15 13:07:38 PDT
Committed r152653: <http://trac.webkit.org/changeset/152653>
Note You need to log in before you can comment on or make changes to this bug.