Bug 118635

Summary:

Fixed position elements should layout relative to transformed container

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Layout and Rendering

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ahmad.saleem792, ap, bdakin, bfulgham, dino, hyatt, jchaffraix, simon.fraser, thorton, webkit-bug-importer, zalan

Priority:

Keywords:

BlinkMergeCandidate, InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Test case shows that we have a bug	none

Ryosuke Niwa

Reported 2013-07-12 22:59:25 PDT

Consider merging https://chromium.googlesource.com/chromium/blink/+/f052baa7402aa050a3e5c633a4b374ecf7162926 The original layer coordinates conversion code contains a bug that it forgets to return for the simple case where the fixed position container found is already the ancestor layer wanted, and the code falls through to the special path intended for RenderFlowThread.

Attachments
Test case shows that we have a bug (973 bytes, text/html) 2022-08-22 15:53 PDT, Simon Fraser (smfr)	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Ahmad Saleem

Comment 1 2022-08-21 16:47:00 PDT

It seems that it is not applied: https://github.com/WebKit/WebKit/blob/90099cb07fc40b47981923bc721f25ea1a31cbec/Source/WebCore/rendering/RenderLayer.cpp#L2407

Simon Fraser (smfr)

Comment 2 2022-08-22 12:20:37 PDT

I think our containing block logic is correct, but there's still a FIXME for this in compositing code.

Simon Fraser (smfr)

Comment 3 2022-08-22 15:53:57 PDT

Created attachment 461806 [details] Test case shows that we have a bug

Simon Fraser (smfr)

Comment 4 2022-08-22 15:59:34 PDT

// FIXME: Handle fixed inside of a transform, which should not behave as fixed.

Simon Fraser (smfr)

Comment 5 2022-08-22 16:46:09 PDT

Pull request: https://github.com/WebKit/WebKit/pull/3560

EWS

Comment 6 2022-08-25 23:48:22 PDT

Committed 253809@main (546a1c950d42): <https://commits.webkit.org/253809@main> Reviewed commits have been landed. Closing PR #3560 and removing active labels.

Radar WebKit Bug Importer

Comment 7 2022-08-25 23:49:16 PDT

<rdar://problem/99174247>

Note You need to log in before you can comment on or make changes to this bug.