Bug 118629

Summary: parseHTMLInteger shouldn't upconvert 8-bit string
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: DOMAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, benjamin, commit-queue, darin, esprehn+autocc, ggaren, msaboff
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 118641    
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2013-07-12 17:08:47 PDT
Merge https://chromium.googlesource.com/chromium/blink/+/e0ebab23e0c16b49dc90c9c39b8bbbf4f243a01e --- a/Source/core/html/parser/HTMLParserIdioms.cpp +++ b/Source/core/html/parser/HTMLParserIdioms.cpp @@ -207,12 +207,12 @@ // Step 1 // Step 2 unsigned length = input.length(); - if (length && input.is8Bit()) { + if (!length || input.is8Bit()) { const LChar* start = input.characters8(); return parseHTMLIntegerInternal(start, start + length, value); } - const UChar* start = input.bloatedCharacters(); + const UChar* start = input.characters16(); return parseHTMLIntegerInternal(start, start + length, value); }
Attachments
Fixes the bug (1.47 KB, patch)
2013-07-12 18:49 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-07-12 18:49:35 PDT
Created attachment 206582 [details] Fixes the bug
WebKit Commit Bot
Comment 2 2013-07-13 08:33:04 PDT
Comment on attachment 206582 [details] Fixes the bug Clearing flags on attachment: 206582 Committed r152610: <http://trac.webkit.org/changeset/152610>
WebKit Commit Bot
Comment 3 2013-07-13 08:33:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.