Summary: | [CoordinatedGraphics] Crash at CoordinatedGraphicsScene::updateImageBacking | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Luciano Wolf <luciano.wolf> | ||||||||
Component: | WebKit Qt | Assignee: | Luciano Wolf <luciano.wolf> | ||||||||
Status: | RESOLVED INVALID | ||||||||||
Severity: | Normal | CC: | cmarcelo, commit-queue, hugo.lima, luiz, marcelo.lira, noam, yoon | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Luciano Wolf
2013-07-12 14:20:49 PDT
Created attachment 206572 [details]
Proposed fix
Created attachment 206669 [details]
Proposed fix.
Comment on attachment 206669 [details] Proposed fix. View in context: https://bugs.webkit.org/attachment.cgi?id=206669&action=review > Source/WebCore/ChangeLog:9 > + operation - solves the issue. > + You should mention why :) It works because when an image is replaced the old one is deleted before the new one is created, and IDs are not unique in cairo (they're based on the image pointer) Created attachment 206673 [details]
Proposed fix.
Comment on attachment 206673 [details] Proposed fix. Clearing flags on attachment: 206673 Committed r152647: <http://trac.webkit.org/changeset/152647> This crash still appears, the patch makes it more rare but doesn't fix it. The right fix for this is to stop using the Cairo pointer as an image ID, but rather have a map in the WebProcess between a referenced cairo surface and an image ID. See previous comment. The Qt port has been removed from WebKit, resolving this bug. |