Bug 118606
| Summary: | [Win] R152573 broke Windows build | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Zoltan Arvai <zarvai> |
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | Normal | CC: | abrhm, allan.jensen, ggaren, jturcotte, kadam, oliver, ossy |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Zoltan Arvai
After http://trac.webkit.org/changeset/152573 Windows build is broken.
There was a fix in http://trac.webkit.org/changeset/152577, but some problem remained:
JITThunks.cpp
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(383) : error C2066: cast to function type is illegal
C:\buildslave\qt-windows-32bit-release\build\Source\JavaScriptCore\jit\JITThunks.cpp(84) : see reference to function template instantiation 'std::pair<_Ty1,_Ty2> std::make_pair<JSC::EncodedJSValue(__fastcall *&)(JSC::ExecState *),JSC::EncodedJSValue(JSC::ExecState *)>(__int64,_Ty2 (__fastcall &))' being compiled
with
[
_Ty1=__int64 (__fastcall *)(JSC::ExecState *),
_Ty2=__int64 (JSC::ExecState *)
]
c:\Program Files (x86)\Microsoft Visual Studio 10.0\VC\INCLUDE\utility(254) : error C3867: 'std::_Pair_base<_Ty1,_Ty2>::second': function call missing argument list; use '&std::_Pair_base<_Ty1,_Ty2>::second' to create a pointer to member
with
[
_Ty1=__int64 (__fastcall *)(JSC::ExecState *),
_Ty2=__int64 (JSC::ExecState *)
]
C:\buildslave\qt-windows-32bit-release\build\Source\JavaScriptCore\jit\JITThunks.cpp(84) : see reference to function template instantiation 'std::pair<_Ty1,_Ty2>::pair<__int64(__fastcall *)(JSC::ExecState *),__int64(JSC::ExecState *)>(std::pair<_Ty1,__int64 (JSC::ExecState *)> &&)' being compiled
with
[
_Ty1=JSC::NativeFunction,
_Ty2=JSC::NativeFunction
]
The following bots are affected:
Apple Win Debug (Build) http://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/68295/steps/compile-webkit/logs/stdio
Apple Win Release (Build) http://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/50133/steps/compile-webkit/logs/stdio
Qt Windows http://build.webkit.org/builders/Qt%20Windows%2032-bit%20Release/builds/66798/steps/compile-webkit/logs/stdio
Could you check it, please?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
*** This bug has been marked as a duplicate of bug 118610 ***