Bug 118562

Summary: Insufficient viewport repaints when FrameView::paintsEntireContents
Product: WebKit Reporter: Allan Sandfeld Jensen <allan.jensen>
Component: Layout and RenderingAssignee: Allan Sandfeld Jensen <allan.jensen>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, noam, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Allan Sandfeld Jensen
Reported 2013-07-11 05:42:05 PDT
If FrameView::paintsEntireContents is true, and the frameView is resized, the repaints emitted by the render-tree are wrongly limited to the frameRect. It appears to be because the visualOverflow of a renderview is equal frameRect. Since paints to contents implies no clipping or only clipping to total contents, the visualOverflow of RenderView should match the layoutOverflow.
Attachments
Patch (2.47 KB, patch)
2013-07-11 05:47 PDT, Allan Sandfeld Jensen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Allan Sandfeld Jensen
Comment 1 2013-07-11 05:47:47 PDT
Created attachment 206450 [details] Patch
Allan Sandfeld Jensen
Comment 2 2013-07-11 05:50:13 PDT
This solves a bug that happens on the Qt port if TiledBackingStore is enabled but ResizesToContent is not. To trigger the issue open a page with centered content, scroll down and resize the width. Typically only part of the viewport will be repainted, and if you scroll more tiles not repainted can be seen.
WebKit Commit Bot
Comment 3 2013-07-12 01:23:09 PDT
Comment on attachment 206450 [details] Patch Clearing flags on attachment: 206450 Committed r152584: <http://trac.webkit.org/changeset/152584>
WebKit Commit Bot
Comment 4 2013-07-12 01:23:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.