Bug 118560

Summary: DFG should support intrinsic for Math.pow().
Product: WebKit Reporter: Vladislav <vlad>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Enhancement CC: benjamin, bfulgham, fpizlo, ggaren, mhahnenberg, msaboff, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
The patch fpizlo: review+

Vladislav
Reported 2013-07-11 05:13:41 PDT
DFG intrinsic as opposed to old JIT intrinsic can use speculative information about types. Also it allows to process constants at compile time. Concrete assembler for ARMv7 is used for better performance (MacroAssembler and calls to C functions for other architectures).
Attachments
The patch (25.73 KB, patch)
2013-07-11 05:49 PDT, Vladislav 		fpizlo: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vladislav
Comment 1 2013-07-11 05:49:36 PDT
Created attachment 206452 [details] The patch
Vladislav
Comment 2 2013-07-26 06:34:46 PDT
It gives about 12% speedup on SunSpider's math-partial-sums on ARMv7 Linux while neutral on other tests.
Brent Fulgham
Comment 3 2013-10-30 10:26:10 PDT
This seems like a good idea. Is there any reason it's not being merged?
Filip Pizlo
Comment 4 2013-10-30 11:31:11 PDT
Comment on attachment 206452 [details] The patch r=me. Can you rebase?
Vladislav
Comment 5 2013-10-31 08:01:25 PDT
(In reply to comment #4) > (From update of attachment 206452 [details]) > r=me. Can you rebase? Sure.
Benjamin Poulain
Comment 6 2015-02-18 17:32:30 PST
*** This bug has been marked as a duplicate of bug 141540 ***
Note You need to log in before you can comment on or make changes to this bug.