Bug 118536

Summary: Non-Cairo platforms should be able to use EGL
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: WebGLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: commit-queue
Priority: P4    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
Patch none

Alex Christensen
Reported 2013-07-10 12:12:23 PDT
GLContextEGL.cpp does not compile successfully on non-Cairo platforms (such as the Apple Win port) because it includes cairo.h and has one call to a cairo function. These should be put inside of USE(CAIRO) macros.
Attachments
patch (1.47 KB, patch)
2013-07-10 12:14 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (1.46 KB, patch)
2013-07-18 13:53 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2013-07-10 12:14:27 PDT
Created attachment 206405 [details] patch
Alex Christensen
Comment 2 2013-07-18 13:53:20 PDT
Created attachment 207019 [details] Patch
Brent Fulgham
Comment 3 2013-07-18 13:57:06 PDT
Comment on attachment 207019 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=207019&action=review r=me > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:28 > +#include <cairo.h> I guess the 2D drawing stuff is not brought in with the 3D graphics context. We may end up with a big ifdef block here. > Source/WebCore/platform/graphics/egl/GLContextEGL.cpp:229 > +#endif Ditto -- other platforms will probably have similar cleanup requirements.
WebKit Commit Bot
Comment 4 2013-07-18 15:10:59 PDT
Comment on attachment 207019 [details] Patch Clearing flags on attachment: 207019 Committed r152869: <http://trac.webkit.org/changeset/152869>
WebKit Commit Bot
Comment 5 2013-07-18 15:11:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.