| Summary: | [Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Fabienne Semeria <fsemeria> | ||||||
| Component: | WebCore Misc. | Assignee: | Allan Sandfeld Jensen <allan.jensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | alikhtarev, allan.jensen, commit-queue, jbriance, jturcotte, milian.wolff, noam | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Bug Depends on: | 119740 | ||||||||
| Bug Blocks: | 110211 | ||||||||
| Attachments: |
|
||||||||
|
Description
Fabienne Semeria
2013-07-10 09:07:48 PDT
Created attachment 206393 [details]
fix memory leak in FontCache::getLastResortFallbackFont
Comment on attachment 206393 [details] fix memory leak in FontCache::getLastResortFallbackFont Clearing flags on attachment: 206393 Committed r152563: <http://trac.webkit.org/changeset/152563> All reviewed patches have been landed. Closing bug. It looks like after applying this patch any QtWebKit-based browser crashing on loading this site: http://www.kevs3d.co.uk/dev/canvasmark Tested on Ubuntu 12.04 64bit Indeed, it looks like the Qt version of FontCache::getLastResortFallbackFont may now return a null pointer in some cases. It may be safer to revert the patch until a fix for this is available. Re-opened since this is blocked by bug 119740 Created attachment 208619 [details]
Patch
(In reply to comment #7) > Created an attachment (id=208619) [details] > Patch We tested a patch similar to this one, and it works for us. (In reply to comment #8) > (In reply to comment #7) > > Created an attachment (id=208619) [details] [details] > > Patch > > We tested a patch similar to this one, and it works for us. Great. We also had a case where the old fix crashed Qt browser-demo on 32bit, and the new version doesn't. I never got Alex' example to crash though, can anyone confirm that also works? This patch works fine for me (see bug 119740 and bug 119088). Comment on attachment 208619 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=208619&action=review > Source/WebCore/ChangeLog:8 > + Allocate FontPlatformData on the stack instead on the heap. A note that getCachedFontData does a deep copy of FontPlatformData could be useful to explain why this change is necessary. Committed r154103: <http://trac.webkit.org/changeset/154103> |