Bug 118519

Summary:

Remove some dead code from WebNSURLExtras _web_hostString

Product:

WebKit

Reporter:

Jessie Berlin <jberlin>

Component:

WebKit Misc.

Assignee:

Jessie Berlin <jberlin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, jberlin

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jessie Berlin

Reported 2013-07-09 15:59:00 PDT

- (NSString *)_web_hostString { NSData *data = [self _web_hostData]; if (!data) { data = [NSData data]; } return [[[NSString alloc] initWithData:[self _web_hostData] encoding:NSUTF8StringEncoding] autorelease]; } data isn’t ever used and initWithData:encoding does not throw an exception when data is nil, so we should just remove data.

Attachments
Patch (1.23 KB, patch) 2013-07-09 16:04 PDT, Jessie Berlin	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jessie Berlin

Comment 1 2013-07-09 16:04:22 PDT

Created attachment 206356 [details] Patch

Jessie Berlin

Comment 2 2013-07-10 08:54:22 PDT

Comment on attachment 206356 [details] Patch Committed in http://trac.webkit.org/changeset/152536

Note You need to log in before you can comment on or make changes to this bug.