Summary: | NaturalLoops + Profiler = Crash | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||
Component: | JavaScriptCore | Assignee: | Filip Pizlo <fpizlo> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | fpizlo | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 118338 | ||||||
Attachments: |
|
Description
Mark Hahnenberg
2013-07-08 15:10:28 PDT
Looks like it's more complicated than I thought. Still crashes with this fix. Added https://bugs.webkit.org/show_bug.cgi?id=118338 to the blocks list since SSA conversion needs Dominators and this bug looks like it might be Dominators-related. Yeah I borked dominators. Lol. Patch on the way. (In reply to comment #3) > Yeah I borked dominators. Lol. Patch on the way. See: http://trac.webkit.org/changeset/152431/branches/dfgFourthTier/Source/JavaScriptCore/dfg/DFGDominators.h Notice how I reversed "to" and "from". Created attachment 206289 [details]
the patch
Comment on attachment 206289 [details]
the patch
r=me
Landed in http://trac.webkit.org/changeset/152481 |