Bug 118463

Summary: [CSS Regions] NamedFlowCollection getters should return undefined when there's no NamedFlow
Product: WebKit Reporter: Radu Stavila <stavila>
Component: CSSAssignee: Radu Stavila <stavila>
Status: RESOLVED INVALID    
Severity: Normal CC: cdumez, commit-queue, esprehn+autocc, haraken, kangil.han, kling, menard, mibalan, WebkitBugTracker
Priority: P2 Keywords: WebExposed
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://www.w3.org/TR/2013/WD-css3-regions-20130528/#the-namedflow-interface
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
cdumez: review+, cdumez: commit-queue-
Updated ChangeLog none

Comment 1 Radu Stavila 2013-07-08 09:41:26 PDT
Created attachment 206252 [details]
Patch
Comment 2 Radu Stavila 2013-07-08 09:54:08 PDT
Updated wiki: https://trac.webkit.org/wiki/WebKitIDL#TreatReturnedNullObjectAs
Comment 3 Chris Dumez 2013-07-08 10:52:07 PDT
Comment on attachment 206252 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206252&action=review

Looks good and according to spec. r=me. I'd like someone else to confirm that changing in behavior is OK though before landing as it is web-exposed.

> LayoutTests/ChangeLog:7
> +

Missing Changelog.
Comment 4 Radu Stavila 2013-07-08 10:57:33 PDT
Created attachment 206259 [details]
Updated ChangeLog
Comment 5 Chris Dumez 2013-07-08 11:02:06 PDT
(In reply to comment #3)
> (From update of attachment 206252 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=206252&action=review
> 
> Looks good and according to spec. r=me. I'd like someone else to confirm that changing in behavior is OK though before landing as it is web-exposed.

By someone else, I mean someone with more CSS knowledge than me as this might break compatibility.
Comment 6 Andreas Kling 2013-07-08 14:02:42 PDT
Comment on attachment 206259 [details]
Updated ChangeLog

LGTM.
Comment 7 WebKit Commit Bot 2013-07-08 14:25:22 PDT
Comment on attachment 206259 [details]
Updated ChangeLog

Clearing flags on attachment: 206259

Committed r152466: <http://trac.webkit.org/changeset/152466>
Comment 8 Mihai Balan 2013-08-27 04:54:19 PDT
Manually rolled back in bug 118561. Spec is to be changed.